-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix(docker): Use raw_testspec for test nodes #329
hotfix(docker): Use raw_testspec for test nodes #329
Conversation
52fcc95
to
47fb6bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks
@open-junius , anything holding this? After this PR it would be great if someone could also have a look at the --ws and --rpc flags if they are all correct, because it seems there have been some changes lately removing some of the --ws flags in favor of --rpc |
You are right, we need remove the --ws after upgraded to polkadot 1.0. And other like --ws-max-connections |
@open-junius , would you like me to apply that to this pr, or can it be done after? |
We can do it after upgrade the master branch to polkadot 1.0. the doc is for master. You can create new one after upgrade, and thanks for you update and verify the doc |
01c3a15
to
fb2f456
Compare
@open-junius Is the master on polkadot 1 now, or where can it be tracked? I know the testchain is on v1, and this is a testchain-only fix |
anything holding this? |
See #325